shuffle main.rs to allow deprecation warnings

src/database.rs

@@ -90,10 +90,9 @@ macro_rules! deprecate_with {
 }
 
 impl Config {
-    pub fn fallbacks(mut self) -> Self {
+    pub fn process_fallbacks(&mut self) {
         // TODO: have a proper way handle into above struct (maybe serde supports something like this?)
         deprecate_with!(self ; cache_capacity -> db_cache_capacity or default_db_cache_capacity);
-        self
     }
 }
 

src/main.rs

@@ -194,14 +194,14 @@ async fn main() {
             )
             .merge(Env::prefixed("CONDUIT_").global());
 
-    let config = raw_config
+    std::env::set_var("RUST_LOG", "warn");
+
+    let mut config = raw_config
         .extract::<Config>()
-        .expect("It looks like your config is invalid. Please take a look at the error")
+        .expect("It looks like your config is invalid. Please take a look at the error");
-        .fallbacks();
 
-    let db = Database::load_or_create(config.clone())
+    let mut _span: Option<span::Span> = None;
-        .await
+    let mut _enter: Option<span::Entered<'_>> = None;
-        .expect("config is valid");
 
     if config.allow_jaeger {
         let (tracer, _uninstall) = opentelemetry_jaeger::new_pipeline()
@@ -211,18 +211,22 @@ async fn main() {
         let telemetry = tracing_opentelemetry::layer().with_tracer(tracer);
         Registry::default().with(telemetry).try_init().unwrap();
 
-        let root = span!(tracing::Level::INFO, "app_start", work_units = 2);
+        _span = Some(span!(tracing::Level::INFO, "app_start", work_units = 2));
-        let _enter = root.enter();
+        _enter = Some(_span.as_ref().unwrap().enter());
-
-        let rocket = setup_rocket(raw_config, db);
-        rocket.launch().await.unwrap();
     } else {
-        std::env::set_var("RUST_LOG", config.log);
+        std::env::set_var("RUST_LOG", &config.log);
         tracing_subscriber::fmt::init();
+    }
+
+    // Required here to process fallbacks while logging is enabled, but before config is actually used for anything
+    config.process_fallbacks();
+
+    let db = Database::load_or_create(config)
+        .await
+        .expect("config is valid");
 
     let rocket = setup_rocket(raw_config, db);
     rocket.launch().await.unwrap();
-    }
 }
 
 #[catch(404)]