Browse Source

fix fmt and clippy warnings

merge-requests/95/head
hamidreza kalbasi 5 years ago
parent
commit
13c6c5f2e6
  1. 26
      src/client_server/media.rs
  2. 9
      src/database/globals.rs
  3. 22
      src/database/media.rs

26
src/client_server/media.rs

@ -36,13 +36,15 @@ pub async fn create_content_route(
db.globals.server_name(), db.globals.server_name(),
utils::random_string(MXC_LENGTH) utils::random_string(MXC_LENGTH)
); );
db.media.create( db.media
.create(
mxc.clone(), mxc.clone(),
&db.globals, &db.globals,
&body.filename.as_deref(), &body.filename.as_deref(),
&body.content_type.as_deref(), &body.content_type.as_deref(),
&body.file, &body.file,
).await?; )
.await?;
db.flush().await?; db.flush().await?;
@ -90,13 +92,15 @@ pub async fn get_content_route(
) )
.await?; .await?;
db.media.create( db.media
.create(
mxc, mxc,
&db.globals, &db.globals,
&get_content_response.content_disposition.as_deref(), &get_content_response.content_disposition.as_deref(),
&get_content_response.content_type.as_deref(), &get_content_response.content_type.as_deref(),
&get_content_response.file, &get_content_response.file,
).await?; )
.await?;
Ok(get_content_response.into()) Ok(get_content_response.into())
} else { } else {
@ -117,7 +121,9 @@ pub async fn get_content_thumbnail_route(
if let Some(FileMeta { if let Some(FileMeta {
content_type, file, .. content_type, file, ..
}) = db.media.get_thumbnail( }) = db
.media
.get_thumbnail(
mxc.clone(), mxc.clone(),
&db.globals, &db.globals,
body.width body.width
@ -126,7 +132,9 @@ pub async fn get_content_thumbnail_route(
body.height body.height
.try_into() .try_into()
.map_err(|_| Error::BadRequest(ErrorKind::InvalidParam, "Width is invalid."))?, .map_err(|_| Error::BadRequest(ErrorKind::InvalidParam, "Width is invalid."))?,
).await? { )
.await?
{
Ok(get_content_thumbnail::Response { file, content_type }.into()) Ok(get_content_thumbnail::Response { file, content_type }.into())
} else if &*body.server_name != db.globals.server_name() && body.allow_remote { } else if &*body.server_name != db.globals.server_name() && body.allow_remote {
let get_thumbnail_response = db let get_thumbnail_response = db
@ -145,7 +153,8 @@ pub async fn get_content_thumbnail_route(
) )
.await?; .await?;
db.media.upload_thumbnail( db.media
.upload_thumbnail(
mxc, mxc,
&db.globals, &db.globals,
&None, &None,
@ -153,7 +162,8 @@ pub async fn get_content_thumbnail_route(
body.width.try_into().expect("all UInts are valid u32s"), body.width.try_into().expect("all UInts are valid u32s"),
body.height.try_into().expect("all UInts are valid u32s"), body.height.try_into().expect("all UInts are valid u32s"),
&get_thumbnail_response.file, &get_thumbnail_response.file,
).await?; )
.await?;
Ok(get_thumbnail_response.into()) Ok(get_thumbnail_response.into())
} else { } else {

9
src/database/globals.rs

@ -5,7 +5,12 @@ use ruma::{
EventId, MilliSecondsSinceUnixEpoch, ServerName, ServerSigningKeyId, EventId, MilliSecondsSinceUnixEpoch, ServerName, ServerSigningKeyId,
}; };
use rustls::{ServerCertVerifier, WebPKIVerifier}; use rustls::{ServerCertVerifier, WebPKIVerifier};
use std::{collections::{BTreeMap, HashMap}, path::{PathBuf}, sync::{Arc, RwLock}, time::{Duration, Instant}}; use std::{
collections::{BTreeMap, HashMap},
path::PathBuf,
sync::{Arc, RwLock},
time::{Duration, Instant},
};
use tokio::sync::Semaphore; use tokio::sync::Semaphore;
use trust_dns_resolver::TokioAsyncResolver; use trust_dns_resolver::TokioAsyncResolver;
@ -268,7 +273,7 @@ impl Globals {
r r
} }
pub fn get_media_file(&self, key: &Vec<u8>) -> PathBuf { pub fn get_media_file(&self, key: &[u8]) -> PathBuf {
let mut r = PathBuf::new(); let mut r = PathBuf::new();
r.push(self.config.database_path.clone()); r.push(self.config.database_path.clone());
r.push("media"); r.push("media");

22
src/database/media.rs

@ -1,9 +1,13 @@
use image::{imageops::FilterType, GenericImageView};
use crate::database::globals::Globals; use crate::database::globals::Globals;
use image::{imageops::FilterType, GenericImageView};
use crate::{utils, Error, Result}; use crate::{utils, Error, Result};
use std::{mem}; use std::mem;
use tokio::{fs::{self, File}, io::AsyncWriteExt, io::AsyncReadExt}; use tokio::{
fs::{self, File},
io::AsyncReadExt,
io::AsyncWriteExt,
};
pub struct FileMeta { pub struct FileMeta {
pub filename: Option<String>, pub filename: Option<String>,
@ -153,7 +157,13 @@ impl Media {
/// - Server creates the thumbnail and sends it to the user /// - Server creates the thumbnail and sends it to the user
/// ///
/// For width,height <= 96 the server uses another thumbnailing algorithm which crops the image afterwards. /// For width,height <= 96 the server uses another thumbnailing algorithm which crops the image afterwards.
pub async fn get_thumbnail(&self, mxc: String, globals: &Globals, width: u32, height: u32) -> Result<Option<FileMeta>> { pub async fn get_thumbnail(
&self,
mxc: String,
globals: &Globals,
width: u32,
height: u32,
) -> Result<Option<FileMeta>> {
let (width, height, crop) = self let (width, height, crop) = self
.thumbnail_properties(width, height) .thumbnail_properties(width, height)
.unwrap_or((0, 0, false)); // 0, 0 because that's the original file .unwrap_or((0, 0, false)); // 0, 0 because that's the original file
@ -316,14 +326,14 @@ impl Media {
Ok(Some(FileMeta { Ok(Some(FileMeta {
filename, filename,
content_type, content_type,
file: thumbnail_bytes.to_vec() file: thumbnail_bytes.to_vec(),
})) }))
} else { } else {
// Couldn't parse file to generate thumbnail, send original // Couldn't parse file to generate thumbnail, send original
Ok(Some(FileMeta { Ok(Some(FileMeta {
filename, filename,
content_type, content_type,
file: file.to_vec() file: file.to_vec(),
})) }))
} }
} else { } else {

Loading…
Cancel
Save