Browse Source

fix fmt and clippy warnings

merge-requests/95/head
hamidreza kalbasi 5 years ago
parent
commit
13c6c5f2e6
  1. 76
      src/client_server/media.rs
  2. 9
      src/database/globals.rs
  3. 26
      src/database/media.rs

76
src/client_server/media.rs

@ -36,13 +36,15 @@ pub async fn create_content_route( @@ -36,13 +36,15 @@ pub async fn create_content_route(
db.globals.server_name(),
utils::random_string(MXC_LENGTH)
);
db.media.create(
mxc.clone(),
&db.globals,
&body.filename.as_deref(),
&body.content_type.as_deref(),
&body.file,
).await?;
db.media
.create(
mxc.clone(),
&db.globals,
&body.filename.as_deref(),
&body.content_type.as_deref(),
&body.file,
)
.await?;
db.flush().await?;
@ -90,13 +92,15 @@ pub async fn get_content_route( @@ -90,13 +92,15 @@ pub async fn get_content_route(
)
.await?;
db.media.create(
mxc,
&db.globals,
&get_content_response.content_disposition.as_deref(),
&get_content_response.content_type.as_deref(),
&get_content_response.file,
).await?;
db.media
.create(
mxc,
&db.globals,
&get_content_response.content_disposition.as_deref(),
&get_content_response.content_type.as_deref(),
&get_content_response.file,
)
.await?;
Ok(get_content_response.into())
} else {
@ -117,16 +121,20 @@ pub async fn get_content_thumbnail_route( @@ -117,16 +121,20 @@ pub async fn get_content_thumbnail_route(
if let Some(FileMeta {
content_type, file, ..
}) = db.media.get_thumbnail(
mxc.clone(),
&db.globals,
body.width
.try_into()
.map_err(|_| Error::BadRequest(ErrorKind::InvalidParam, "Width is invalid."))?,
body.height
.try_into()
.map_err(|_| Error::BadRequest(ErrorKind::InvalidParam, "Width is invalid."))?,
).await? {
}) = db
.media
.get_thumbnail(
mxc.clone(),
&db.globals,
body.width
.try_into()
.map_err(|_| Error::BadRequest(ErrorKind::InvalidParam, "Width is invalid."))?,
body.height
.try_into()
.map_err(|_| Error::BadRequest(ErrorKind::InvalidParam, "Width is invalid."))?,
)
.await?
{
Ok(get_content_thumbnail::Response { file, content_type }.into())
} else if &*body.server_name != db.globals.server_name() && body.allow_remote {
let get_thumbnail_response = db
@ -145,15 +153,17 @@ pub async fn get_content_thumbnail_route( @@ -145,15 +153,17 @@ pub async fn get_content_thumbnail_route(
)
.await?;
db.media.upload_thumbnail(
mxc,
&db.globals,
&None,
&get_thumbnail_response.content_type,
body.width.try_into().expect("all UInts are valid u32s"),
body.height.try_into().expect("all UInts are valid u32s"),
&get_thumbnail_response.file,
).await?;
db.media
.upload_thumbnail(
mxc,
&db.globals,
&None,
&get_thumbnail_response.content_type,
body.width.try_into().expect("all UInts are valid u32s"),
body.height.try_into().expect("all UInts are valid u32s"),
&get_thumbnail_response.file,
)
.await?;
Ok(get_thumbnail_response.into())
} else {

9
src/database/globals.rs

@ -5,7 +5,12 @@ use ruma::{ @@ -5,7 +5,12 @@ use ruma::{
EventId, MilliSecondsSinceUnixEpoch, ServerName, ServerSigningKeyId,
};
use rustls::{ServerCertVerifier, WebPKIVerifier};
use std::{collections::{BTreeMap, HashMap}, path::{PathBuf}, sync::{Arc, RwLock}, time::{Duration, Instant}};
use std::{
collections::{BTreeMap, HashMap},
path::PathBuf,
sync::{Arc, RwLock},
time::{Duration, Instant},
};
use tokio::sync::Semaphore;
use trust_dns_resolver::TokioAsyncResolver;
@ -268,7 +273,7 @@ impl Globals { @@ -268,7 +273,7 @@ impl Globals {
r
}
pub fn get_media_file(&self, key: &Vec<u8>) -> PathBuf {
pub fn get_media_file(&self, key: &[u8]) -> PathBuf {
let mut r = PathBuf::new();
r.push(self.config.database_path.clone());
r.push("media");

26
src/database/media.rs

@ -1,9 +1,13 @@ @@ -1,9 +1,13 @@
use image::{imageops::FilterType, GenericImageView};
use crate::database::globals::Globals;
use image::{imageops::FilterType, GenericImageView};
use crate::{utils, Error, Result};
use std::{mem};
use tokio::{fs::{self, File}, io::AsyncWriteExt, io::AsyncReadExt};
use std::mem;
use tokio::{
fs::{self, File},
io::AsyncReadExt,
io::AsyncWriteExt,
};
pub struct FileMeta {
pub filename: Option<String>,
@ -153,7 +157,13 @@ impl Media { @@ -153,7 +157,13 @@ impl Media {
/// - Server creates the thumbnail and sends it to the user
///
/// For width,height <= 96 the server uses another thumbnailing algorithm which crops the image afterwards.
pub async fn get_thumbnail(&self, mxc: String, globals: &Globals, width: u32, height: u32) -> Result<Option<FileMeta>> {
pub async fn get_thumbnail(
&self,
mxc: String,
globals: &Globals,
width: u32,
height: u32,
) -> Result<Option<FileMeta>> {
let (width, height, crop) = self
.thumbnail_properties(width, height)
.unwrap_or((0, 0, false)); // 0, 0 because that's the original file
@ -213,7 +223,7 @@ impl Media { @@ -213,7 +223,7 @@ impl Media {
let path = globals.get_media_file(&key.to_vec());
let mut file = vec![];
File::open(path).await?.read_to_end(&mut file).await?;
let mut parts = key.rsplit(|&b| b == 0xff);
let content_type = parts
@ -310,20 +320,20 @@ impl Media { @@ -310,20 +320,20 @@ impl Media {
fs::create_dir_all(path.parent().unwrap()).await?;
let mut f = File::create(path).await?;
f.write_all(&thumbnail_bytes).await?;
self.mediaid_file.insert(thumbnail_key, vec![])?;
Ok(Some(FileMeta {
filename,
content_type,
file: thumbnail_bytes.to_vec()
file: thumbnail_bytes.to_vec(),
}))
} else {
// Couldn't parse file to generate thumbnail, send original
Ok(Some(FileMeta {
filename,
content_type,
file: file.to_vec()
file: file.to_vec(),
}))
}
} else {

Loading…
Cancel
Save